refactor!: require PHP 8.4
Tests / PHP 8.4 (push) Failing after 5m34s

Drop support for PHP 8.3 and lower. The package now declares >=8.4, and CI runs
only on 8.4.

- composer.json: require php >=8.4.
- mago.toml: php-version = "8.4", matching the minimum supported version.
- phpstan.neon: phpVersion 80400.
- Upgrade phpstan/phpstan to ^2.3: 1.x cannot parse `new Foo()->bar()`, which the
  8.4 formatter now emits.
- Fix the type errors PHPStan 2 reports: class-string<static> variance,
  optional array offsets in fromEnvironment, list vs array for PdoConnection::$lru,
  ReflectionClass<Model> docblocks, Repository made covariant in T, and a redundant
  null comparison in validateRelationPath.
- CI: single PHP 8.4 job using the php:8.4-cli container instead of setup-php,
  which failed with a TLS handshake timeout on the runner.

BREAKING CHANGE: PHP 8.4 is now required.
This commit is contained in:
dgarcia committed 2026-11-15 10:58:11 -03:00
1 parent c15015d809
commit 0e756e45c7
20 files changed
+97 -107

No files matched your search

+2 -2
View File
@@ -23,7 +23,7 @@ final class QueryBuilderTest extends TestCase
protected function setUp(): void
{
$this->builder = new QueryBuilder(new MySqlDialect());
$this->usuarios = (new MetadataFactory())->forClass(Usuario::class);
$this->usuarios = new MetadataFactory()->forClass(Usuario::class);
}
#[Test]
@@ -42,7 +42,7 @@ final class QueryBuilderTest extends TestCase
#[Test]
public function it_excludes_relations_from_the_select_list(): void
{
$metadata = (new MetadataFactory())->forClass(Factura::class);
$metadata = new MetadataFactory()->forClass(Factura::class);
$compiled = $this->builder->select($metadata, []);
self::assertStringNotContainsString('`usuario`', $compiled['sql']);