From 4faad2c46e0af3682282774af2aa5876d8cc6efa Mon Sep 17 00:00:00 2001 From: Dario Garcia Date: Sun, 15 Nov 2026 13:35:27 -0300 Subject: [PATCH] fix(repository): hydrate enum columns instead of failing on read Repository::castDatabaseValue() called TypeCaster::cast() with the enum's class name as the "type", so any row of a model declaring #[Enum] threw "Cannot assign string to property X of type Y" the moment it was read. Writes worked, which is why this survived 1.0.0: the select path is only exercised on read. castDatabaseValue() now delegates to TypeCaster::castEnum() when the property declares one, and keeps the null passthrough. Covered by EnumHydrationTest with a scalar value and a null. --- src/Repository.php | 4 +++ tests/Fixture/ArticuloConEstado.php | 29 +++++++++++++++++++ tests/Unit/EnumHydrationTest.php | 44 +++++++++++++++++++++++++++++ 3 files changed, 77 insertions(+) create mode 100644 tests/Fixture/ArticuloConEstado.php create mode 100644 tests/Unit/EnumHydrationTest.php diff --git a/src/Repository.php b/src/Repository.php index acf5101..84a609d 100644 --- a/src/Repository.php +++ b/src/Repository.php @@ -329,6 +329,10 @@ final class Repository return null; } + if ($definition->enumClass !== null) { + return TypeCaster::castEnum($value, $definition->enumClass, true, $definition->name); + } + return TypeCaster::cast($value, $definition->type, true, $definition->name); } diff --git a/tests/Fixture/ArticuloConEstado.php b/tests/Fixture/ArticuloConEstado.php new file mode 100644 index 0000000..c66b378 --- /dev/null +++ b/tests/Fixture/ArticuloConEstado.php @@ -0,0 +1,29 @@ +rows = [['codigo' => '3', 'nombre' => 'Taladro', 'estado' => 'publicado']]; + + $models = Orm::fromConnection($connection)->repository(ArticuloConEstado::class)->find(); + + self::assertCount(1, $models); + self::assertInstanceOf(ArticuloConEstado::class, $models[0]); + self::assertSame(EstadoArticulo::Publicado, $models[0]->estado); + } + + #[Test] + public function it_hydrates_a_nullable_enum_column_as_null(): void + { + $connection = new FakeConnection(); + $connection->rows = [['codigo' => '4', 'nombre' => 'Sierra', 'estado' => null]]; + + $models = Orm::fromConnection($connection)->repository(ArticuloConEstado::class)->find(); + + self::assertCount(1, $models); + self::assertNull($models[0]->estado); + } +}